Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add funding period in trade result #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fshiori
Copy link
Contributor

@fshiori fshiori commented Jan 15, 2020

Description:

... add funding period in trade result

Breaking changes:

none

New features:

  • add funding period in trade result

Fixes:

none

PR status:

  • Version bumped
  • Change-log updated

@JacobPlaster
Copy link
Contributor

Hey @fshiori, thanks again for opening a PR!

What is the need for period in the trade object? Prehaps you should be using the FundingTrade type?

type FundingTrade struct {

@fshiori
Copy link
Contributor Author

fshiori commented Jan 16, 2020

FundingTrade used for different API.

FundingTrade is for https://docs.bitfinex.com/reference#rest-auth-funding-trades-hist
and Trade is for https://docs.bitfinex.com/reference#rest-public-trades
Although rest-auth-funding-trades-hist can instead of rest-public-trades API
, but FundingService Trades seems not support query string start/end/limit now.
It also need more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants