adding rate limiting to public client subscriptions, increasing subsc… #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riptions limit to 30 as per docs
| @@ -105,6 +111,9 @@ func (m *Mux) Subscribe(sub event.Subscribe) *Mux { | |||
| m.mtx.Lock() | |||
| defer m.mtx.Unlock() | |||
|
|
|||
| // make sure we don't hit the rate limit | |||
| time.Sleep(rateLimit * time.Millisecond) | |||
There was a problem hiding this comment.
hmmm, thats not ideal for people that just use 1 or 5 subscriptions... takes a long time...
how about something that works also well for the many use cases where people have less than 20 connections?
maybe there is a lib for throttling in golang or something we can build with the mutexes we used elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adding a threshold to avoid hitting rate limit when resubscribing to channels
Breaking changes:
N/A
New features:
N/A
Fixes:
PR status: