-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using custom HTTP client #50
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, good idea
What do you think of going one step further adding an interface for HTTPClient so one can use wrapped http.Client's (handling retries, exponential backoff etc.)? |
@jayme-github makes sense. I currently can't work on this as my computer recently got stolen. A separate PR maybe? |
Let's see what the bfx people say. If they'r okay with it, I can send an additional PR (or you've merged my commit into your PR in the meantime :-)) |
If you can file a PR in my fork from yours, I can. But I can't get into actual Git on this computer right now :p |
putting into review/qa for someone from bitfinex to ultimately merge. thank you for the contribution. |
It seems to have an ACK from bitfinex for a long time :D |
any updates on that topic? Would be great to have that merged :) |
Solves #49