Skip to content

Commit

Permalink
ci: bugfix binderhub image not updating on change
Browse files Browse the repository at this point in the history
Chartpress 1.0.0 contained a regression, and our publishing pipeline was
using chartpress 1.0.0 instead of 0.7.0, so it was affected. This made
the image version used by binderhub since chartpress 1.0.0 was released
in 21 Nov 2020 be the same version as the image-cleaner image.

The only PR that was influenced by this mishap was a PR merged ~2 hours.
With this commit, it should not happen again.
  • Loading branch information
consideRatio committed Dec 3, 2020
1 parent d5ecd3d commit 25c0bb0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: |
. ./ci/common
setup_helm v3.4.1
pip install --no-cache-dir chartpress
pip install --no-cache-dir chartpress==1.0.*
- name: Setup push rights to jupyterhub/helm-chart
# This was setup by...
Expand Down
2 changes: 1 addition & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
beautifulsoup4
chartpress==0.7.*
chartpress==1.0.*
click
codecov
html5lib
Expand Down

0 comments on commit 25c0bb0

Please sign in to comment.