Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17411] Pull simulator type/version from file for testing #226

Merged
merged 15 commits into from
Feb 4, 2025

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented Feb 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17411

📔 Objective

In order to get PR 217 to merge in, we have to make it easier for workflows to change iOS versions and test simulators. This adapts the current logic from the PM app to here in order to facilitate that, and avoid problems when we merge the repositories.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsa0648101-88f7-49f6-b611-d7835bf7a4e2

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (18f6811) to head (c773d8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         215      215           
  Lines        9873     9873           
=======================================
  Hits         6937     6937           
  Misses       2936     2936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatherineInCode KatherineInCode marked this pull request as ready for review February 4, 2025 15:16
@KatherineInCode KatherineInCode requested a review from a team as a code owner February 4, 2025 15:16
@KatherineInCode KatherineInCode changed the title Pull simulator type/version from file for testing [PM-17411] Pull simulator type/version from file for testing Feb 4, 2025
@KatherineInCode KatherineInCode merged commit dc7beeb into main Feb 4, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the katherine/dynamic-simulator branch February 4, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants