fix broken blockedInteractionsUris state contruction

bitwarden · Jan 10, 2025 · ac7525a · ac7525a
1 parent 3c99493
commit ac7525a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/apps/browser/src/platform/services/browser-script-injector.service.spec.ts b/apps/browser/src/platform/services/browser-script-injector.service.spec.ts
@@ -63,7 +63,7 @@ describe("ScriptInjectorService", () => {
     configService.getFeatureFlag$.mockImplementation(() => of(false));
     domainSettingsService = new DefaultDomainSettingsService(fakeStateProvider, configService);
     domainSettingsService.equivalentDomains$ = of(mockEquivalentDomains);
-    domainSettingsService.blockedInteractionsUris$ = of(null);
+    domainSettingsService.blockedInteractionsUris$ = of({});
     scriptInjectorService = new BrowserScriptInjectorService(
       domainSettingsService,
       platformUtilsService,

diff --git a/apps/browser/src/tools/background/fileless-importer.background.spec.ts b/apps/browser/src/tools/background/fileless-importer.background.spec.ts
@@ -39,7 +39,7 @@ describe("FilelessImporterBackground ", () => {
   let tabMock: chrome.tabs.Tab;
 
   beforeEach(() => {
-    domainSettingsService.blockedInteractionsUris$ = of(null);
+    domainSettingsService.blockedInteractionsUris$ = of({});
     policyService.policyAppliesToActiveUser$.mockImplementation(() => of(true));
     scriptInjectorService = new BrowserScriptInjectorService(
       domainSettingsService,

diff --git a/libs/common/src/autofill/services/domain-settings.service.spec.ts b/libs/common/src/autofill/services/domain-settings.service.spec.ts
@@ -29,7 +29,7 @@ describe("DefaultDomainSettingsService", () => {
 
     jest.spyOn(domainSettingsService, "getUrlEquivalentDomains");
     domainSettingsService.equivalentDomains$ = of(mockEquivalentDomains);
-    domainSettingsService.blockedInteractionsUris$ = of(null);
+    domainSettingsService.blockedInteractionsUris$ = of({});
   });
 
   describe("getUrlEquivalentDomains", () => {

diff --git a/libs/common/src/autofill/services/domain-settings.service.ts b/libs/common/src/autofill/services/domain-settings.service.ts
@@ -36,7 +36,7 @@ const BLOCKED_INTERACTIONS_URIS = new KeyDefinition(
   DOMAIN_SETTINGS_DISK,
   "blockedInteractionsUris",
   {
-    deserializer: (value: NeverDomains) => value ?? null,
+    deserializer: (value: NeverDomains) => value ?? {},
   },
 );
 
@@ -131,7 +131,7 @@ export class DefaultDomainSettingsService implements DomainSettingsService {
         switchMap((featureIsEnabled) =>
           featureIsEnabled ? this.blockedInteractionsUrisState.state$ : of({} as NeverDomains),
         ),
-        map((disabledUris) => (Object.keys(disabledUris).length ? disabledUris : null)),
+        map((disabledUris) => (Object.keys(disabledUris).length ? disabledUris : {})),
       );
 
     this.equivalentDomainsState = this.stateProvider.getActive(EQUIVALENT_DOMAINS);