-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10570] Ensuring strategy exists before doing "in" check. Fixes "TypeError: C… #10387
Conversation
…annot use 'in' operator to search for 'email$' in null"
Thank you for your contribution! We've added this to our internal Community PR board for review. |
@rr-bw Could I please get a review? |
Thank you for reaching out. We are currently reviewing the change in accordance with our Contribution Review Process. We need to assess how the change impacts other internal initiatives or other work in that particular area of the codebase. We hope you understand, and we appreciate your patience. |
When session times out and "send verification code email again" link is clicked, the following error occurs and no feedback is given to user.
TypeError: Cannot use 'in' operator to search for 'email$' in null
This change ensure strategy object exists before calling "in".
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes