Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16906] add close button to password history dialog #12790

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

audreyality
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16906

📔 Objective

bit-dialog overlaps the electron windows' dragable “title” area. While waiting for a fix from UIF, this should be mitigated by adding a “close” button to the password history dialog box.

📸 Screenshots

Empty:
image

Lots of entries:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner January 9, 2025 20:55
@audreyality audreyality changed the title add close button to passoword history dialog [PM-16906] add close button to passoword history dialog Jan 9, 2025

This comment was marked as resolved.

This comment was marked as resolved.

@audreyality audreyality changed the title [PM-16906] add close button to passoword history dialog [PM-16906] add close button to password history dialog Jan 10, 2025
@@ -52,7 +54,13 @@ export class CredentialGeneratorHistoryDialogComponent {
.subscribe(this.hasHistory$);
}

clear = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, the only reason to use the arrow function here would be if we wanted to use AsyncAction handlers

@audreyality audreyality merged commit 0456648 into main Jan 14, 2025
94 checks passed
@audreyality audreyality deleted the tools/pm-16906/close-button branch January 14, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants