Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16914] in desktop "Allow browser integration" button fails on dev environment, but should pass fine. #12797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mzieniukbw
Copy link
Contributor

@mzieniukbw mzieniukbw commented Jan 10, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16914

๐Ÿ“” Objective

Desktop settings "Allow browser integration" platform support check not working as expected.

Also dev builds will fail, even though the platform supported check should be suppressed.

Non dev-builds likely ignoges the unsupported platform check - regression.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested a review from a team January 10, 2025 00:34
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ c939450c-9290-41b9-b2a6-186ff41dc41f

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@8cabb36). Learn more about missing BASE report.
Report is 1 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12797   +/-   ##
=======================================
  Coverage        ?   34.14%           
=======================================
  Files           ?     2936           
  Lines           ?    90416           
  Branches        ?    16986           
=======================================
  Hits            ?    30869           
  Misses          ?    57090           
  Partials        ?     2457           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants