[PM-16956] Bugfix - Fix broken blockedInteractionsUris state construction #12813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12813 +/- ##
==========================================
- Coverage 34.14% 34.13% -0.01%
==========================================
Files 2936 2936
Lines 90433 90433
Branches 16989 16989
==========================================
- Hits 30876 30871 -5
- Misses 57100 57105 +5
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
jprusik
commented
Jan 10, 2025
| @@ -131,7 +131,7 @@ export class DefaultDomainSettingsService implements DomainSettingsService { | |||
| switchMap((featureIsEnabled) => | |||
| featureIsEnabled ? this.blockedInteractionsUrisState.state$ : of({} as NeverDomains), | |||
| ), | |||
| map((disabledUris) => (Object.keys(disabledUris).length ? disabledUris : null)), | |||
There was a problem hiding this comment.
would fail at Object.keys(disabledUris) with disabledUris being "null or undefined". Resolved with a fallback state of {}
|
No New Or Fixed Issues Found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16956
📔 Objective
Fix issue where state evaluation would fail, preventing injections from occurring
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes