-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1614] Updated webpack config #352
Conversation
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(can certainly wait for team review)
See the same at https://github.com/bitwarden/clients/blob/1d7360bfdd36248f19aa048bd1012353e2c6f3b9/apps/desktop/webpack.renderer.js#L20-L32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for investigating this!
My suggestion is that this is merged without QA, given that master
is totally broken without it, then QA can regression test everything after you've done the dependency upgrade ticket. Save them testing it twice. Please double check with them first though.
@eliykat thanks for reviewing. The dependency upgrades have already been done so by testing this branch we'll be testing those changes also. |
Type of change
Objective
Directory-connector was upgraded to Angular v15 and the electron build has stopped working since.
This PR fixes that by adding a missing webpack config.
Code changes
Testing requirements
Test that both the CLI and the App work as expected.
Before you submit
npm run lint
) (required)