Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1614] Updated webpack config #352

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Aug 31, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Directory-connector was upgraded to Angular v15 and the electron build has stopped working since.
This PR fixes that by adding a missing webpack config.

Code changes

  • webpack.renderer.js: Added required webpack configuration
  • jslib/angular/src/components/callout.component.html: Ran prettier
  • jslib/common/src/enums/importOptions.ts: Ran prettier
  • src/app/tabs/dashboard.component.html: Ran prettier
  • src/app/tabs/more.component.html: Ran prettier

Testing requirements

Test that both the CLI and the App work as expected.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@bitwarden-bot
Copy link

bitwarden-bot commented Aug 31, 2023

Logo
Checkmarx One – Scan Summary & Details1338744b-9c2a-41d2-b4b8-c822fdd9c361

No New Or Fixed Issues Found

@r-tome r-tome added the needs-qa label Sep 1, 2023
@r-tome r-tome marked this pull request as ready for review September 1, 2023 09:32
@r-tome r-tome requested a review from a team as a code owner September 1, 2023 09:32
withinfocus
withinfocus previously approved these changes Sep 1, 2023
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eliykat
eliykat previously approved these changes Sep 4, 2023
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for investigating this!

My suggestion is that this is merged without QA, given that master is totally broken without it, then QA can regression test everything after you've done the dependency upgrade ticket. Save them testing it twice. Please double check with them first though.

@r-tome
Copy link
Contributor Author

r-tome commented Sep 4, 2023

@eliykat thanks for reviewing. The dependency upgrades have already been done so by testing this branch we'll be testing those changes also.

@r-tome r-tome dismissed stale reviews from eliykat and withinfocus via bb545fe September 19, 2023 13:41
@r-tome r-tome requested a review from eliykat September 19, 2023 14:00
@eliykat eliykat removed their request for review September 25, 2023 03:26
@r-tome r-tome removed the needs-qa label Sep 26, 2023
@r-tome r-tome merged commit 26e4930 into master Sep 26, 2023
11 checks passed
@r-tome r-tome deleted the ac/ac-1614/fix-directory-connector-build branch September 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants