Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atomic PR ID job - Callable Workflow #211

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joseph-flinn
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Testing idea of atomic and testable workflow jobs

๐Ÿšง Type of change

  • ๐Ÿš€ New feature development
  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

Add an atomic job to pull the PR ID that is associated with a commit SHA

๐Ÿ“‹ Code changes

  • .github/workflows/_get_pr_id.yml: Callable workflow to pull the PR ID associated with the repo and commit SHA via the GitHub API using the local GitHub TOKEN.
  • .github/workflows/test_get_pr_id.yml: Test workflow that runs every time that the atomic PR ID job is updated

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@joseph-flinn joseph-flinn requested a review from a team as a code owner November 21, 2023 21:37
@joseph-flinn joseph-flinn marked this pull request as draft November 21, 2023 21:42
@joseph-flinn joseph-flinn changed the title Add atomic PR ID job Add atomic PR ID job - Callable Workflow Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant