Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-511] Add example workflow templates to gh-actions repo #360

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

AmyLGalles
Copy link
Contributor

🎟️ Tracking

BRE-511 Create Workflow Templates for Frequently Used Workflows

📔 Objective

Github provides "Starter workflows" that can be altered for specific situations and at Bitwarden we have a number of workflows that get used over and over with our own conventions. I took the two most common workflow types and annotated them at the first occurrence of each option as a starting point for developers creating their own workflows.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner January 13, 2025 18:34
Copy link

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Detailse8560625-a2c5-4e93-a12a-2cd0ff52c158

Great job, no security vulnerabilities found in this Pull Request

@AmyLGalles AmyLGalles requested a review from pixman20 January 15, 2025 15:21
.github/templates/workflow-templates/build.yml Outdated Show resolved Hide resolved
@AmyLGalles AmyLGalles merged commit 6805e6a into main Jan 24, 2025
5 checks passed
@AmyLGalles AmyLGalles deleted the agalles/workflow-templates branch January 24, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants