Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8372] Generate higher minimum number/special character values #3260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

b02860de585071a2
Copy link
Mannequin

@b02860de585071a2 b02860de585071a2 mannequin commented May 24, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes #3259

Code changes

Context: see desktop blob and mobile blob for comparison.

  • src/Core/Pages/Generator/GeneratorPage.xaml: Change max value of MinNumber and MinSpecial (5 -> 9)

I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.

@bitwarden-bot
Copy link
Mannequin

bitwarden-bot mannequin commented May 24, 2024

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-8372

@bitwarden-bot bitwarden-bot mannequin changed the title Update mobile password generator to support higher minimum number/spe… [PM-8372] Update mobile password generator to support higher minimum number/spe… May 24, 2024
@bitwarden-bot bitwarden-bot mannequin added the community-pr label May 24, 2024
@b02860de585071a2 b02860de585071a2 mannequin changed the title [PM-8372] Update mobile password generator to support higher minimum number/spe… [PM-8372] Generate higher minimum number/special character values May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android password generator does not support minimum number/special character values >5
3 participants