Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore if setting branchConcurrentLimit resolves bug #12

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jul 23, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Renovate isn't opening all the PRs that we expect. Explore if we can explicitly set branchConcurrentLimit to 0 to force it to open as many PRs as possible.

Per the documentation https://docs.renovatebot.com/configuration-options/#branchconcurrentlimit it should inherit the value from prConcurrentLimit but this doesn't seem to be the case as the logs mentions branch limits.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner July 23, 2024 14:39
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@Hinton Hinton merged commit 44b6dde into main Jul 23, 2024
1 check passed
@Hinton Hinton deleted the Hinton-patch-1 branch July 23, 2024 14:59
@Hinton Hinton mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants