Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static akuity version file #6

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mimartin12
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/DEVOPS-1894

🚧 Type of change

  • 🧹 Tech debt (refactoring, code cleanup, dependency

📔 Objective

The static version file for Akuity is will be managed by this workflow, https://github.com/bitwarden/devops/pull/2173. Allowing it to be automatically updated.

📋 Code changes

  • external_dependencies/akuity-versions.json: Add initial static version file.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- The static version file for Akuity is will be managed by this workflow bitwarden/devops#2173. Allowing it to be automatically updated.
@mimartin12 mimartin12 requested a review from a team as a code owner April 5, 2024 14:55
@mimartin12 mimartin12 requested a review from a team April 5, 2024 14:55
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and the linked workflow is managing things. I assume the automation will undo my newline comment so this can probably just go.

}
]
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ End in a newline.

@mimartin12
Copy link
Contributor Author

Seems fine and the linked workflow is managing things. I assume the automation will undo my newline comment so this can probably just go.

Yeah, pretty much, this is just the initial file and will be overwritten shortly after the workflow runs.

@mimartin12 mimartin12 merged commit 176b513 into main Apr 5, 2024
3 checks passed
@mimartin12 mimartin12 deleted the DEVOPS-1894-add-static-version-file branch April 5, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants