set LED pin in config, set animation in config, sleep timer fix, ping function #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent wirings, implemented davids_wiring
davidsalb
changed the title
changed led_pin = 18, as it is the documented pin
# Conflicts: # wordclock_config/wordclock_config.example.cfg
bk1285
reviewed
Jul 24, 2021
|
|
||
| def setBrightness(self, brightness): | ||
| # def setBrightness(self, brightness): |
| @@ -22,15 +22,20 @@ developer_mode = False | |||
| language = german | |||
|
|
|||
| # Choose wiring layout here. Options are: bernds_wiring, christians_wiring, ... (possibly you need your own wiring layout) | |||
| wiring_layout = bernds_wiring | |||
| wiring_layout = davids_wiring | |||
There was a problem hiding this comment.
Please reset to default value (bernds_wiring is part of the docs on how to build the hardware and therefore widely used).
|
|
||
| # Fonts available at /usr/share/fonts/... (e.g. some types listed in truetype/freefont) | ||
| # FreeMono FreeMonoBoldOblique FreeSans FreeSansBoldOblique FreeSerif FreeSerifBoldItalic | ||
| # FreeMonoBold FreeMonoOblique FreeSansBold FreeSansOblique FreeSerifBold FreeSerifItalic | ||
| default_font = wcfont | ||
|
|
||
| # Set the brightness of the display (between 1 and 255) | ||
| brightness = 200 | ||
| brightness = 255 | ||
| use_brightness_sensor = True |
| # animate new time with typewriter animation | ||
| typewriter = false | ||
| typewriter_speed = 10 | ||
| # animate new time. Options: no_animation, typewriter, fadeOutIn |
There was a problem hiding this comment.
Nice! Implementation wasn't properly updated to a (hopefully growing) number of animations so far.
|
|
||
| [ping_checker] | ||
| # ping device IPs to check if somebody home, if not turn off brightness | ||
| activate = True |
| self.animation = "typewriter" if self.typewriter else "fadeOutIn" | ||
| if not any([self.animation == animation_type for animation_type in ['typewriter', 'fadeOutIn']]): | ||
| self.animation = None | ||
| # self.animation = "typewriter" if self.animation else "fadeOutIn" |
There was a problem hiding this comment.
Please remove commented code. Overall, however, a very nice improvement!
| self.ping_activated = config.getboolean('ping_checker', 'activate') | ||
| except: | ||
| print('Do not ping devices.') | ||
| self.ping_activated = True |
There was a problem hiding this comment.
Set to False, if ping_checker is not set...
| try: | ||
| self.ping_activated = config.getboolean('ping_checker', 'activate') | ||
| except: | ||
| print('Do not ping devices.') |
| self.LED_PIN = config.getint('wordclock_display', 'led_pin') # GPIO pin connected to the pixels (must support PWM!). | ||
| except: | ||
| # For backward compatibility | ||
| self.LED_PIN = 10 |
There was a problem hiding this comment.
set to 18, in order to be backward compatible
|
Hi @davidsalb, thanks for opening the PR. Please take a look a the review and consider according changes. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
maybe the things I've done or parts of it are useful. The contribution consists of four commits:
-1. In the config-file the time settings had inline comments which messed with the readout of the parameters. I changed the descriptive comments to be one line above the time-parameters.
-2. The actual decision making to activate sleep mode wasn't working. I changed it and it works for me (also skipping the sleep cycle works)
shut_off_duration) has passed without successful ping, the brightness is set to 0 to save energy. The activation of the ping_function, the IP's of the devices to be pinged and theshut_off_durationare set in the configuration file.