Replace private jax modules with public API #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing type and function imported from a private jax modules with the public API to avoid potential future breakages due to changes in the private modules similar to #43. - `jax._src.interpreters.batching.Array` => `jax.Array` - `jax._src.nn.functions.softmax` => `jax.nn.softmax`
genehack
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #44
Replacing type and function imported from a private jax modules with the
public API to avoid potential future breakages due to changes in the
private modules similar to #43.
jax._src.interpreters.batching.Array=>jax.Arrayjax._src.nn.functions.softmax=>jax.nn.softmax