-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paramminer finish() repeating checks bug #2177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidsec
changed the title
Fixing paramminer finsh() bug
Fixing paramminer finish() bug
Jan 15, 2025
liquidsec
changed the title
Fixing paramminer finish() bug
Fix paramminer finish() repeating checks bug
Jan 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2177 +/- ##
=====================================
- Coverage 93% 93% -0%
=====================================
Files 376 376
Lines 29154 29167 +13
=====================================
+ Hits 26932 26943 +11
- Misses 2222 2224 +2 ☔ View full report in Codecov by Sentry. |
TheTechromancer
approved these changes
Jan 15, 2025
TheTechromancer
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a serious bug with the paramminer finish() method that was causing the same parameters to be checked multiple times and make bigger scans take a ridiculous amount of time.
Related Issue:
#2159
Summary of Changes
Centralized Parameter Handling:
Moved the logic for adding new parameters to self.extracted_words_master to the handle_event method only, ensuring only new parameters not in the wordlist are added, and only from WEB_PARAMETER events.
Simplified finish Method:
Streamlined the finish method by directly using a set comprehension in a single operation to filter and process extracted_words_master.
The use of list operations to remove already checked parameters was also very inefficient.
Event Filtering Enhancement:
Now Filtering URLs ending in
.pdfa static extension