PDS: Implemented Import Repo API #57
Open
+523
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRipperoni
changed the title
afbase
reviewed
Feb 12, 2025
…ng the CarReader read the stream itself - Added Unit tests for reading the car stream
afbase
reviewed
Feb 13, 2025
|
See TheRipperoni#1 |
# Conflicts: # rsky-pds/src/apis/mod.rs
afbase
suggested changes
Feb 14, 2025
| return Outcome::Error((Status::BadRequest, error)); | ||
| } | ||
|
|
||
| let import_datastream = data.open(content_length.megabytes()); |
There was a problem hiding this comment.
Suggested change
| let import_datastream = data.open(content_length.megabytes()); | |
| let import_datastream = data.open(content_length.bytes()); |
| "Content-Length is greater than maximum of {max_import_size}" | ||
| )); | ||
| req.local_cache(|| Some(error.clone())); | ||
| return Outcome::Error((Status::BadRequest, error)); |
There was a problem hiding this comment.
Suggested change
| return Outcome::Error((Status::BadRequest, error)); | |
| return Outcome::Error((Status::PayloadTooLarge, error)); |
| None => { | ||
| let error = ApiError::InvalidRequest("Missing content-length header".to_string()); | ||
| req.local_cache(|| Some(error.clone())); | ||
| Outcome::Error((Status::BadRequest, error)) |
There was a problem hiding this comment.
Suggested change
| Outcome::Error((Status::BadRequest, error)) | |
| Outcome::Error((Status::LengthRequired, error)) |
| req.local_cache(|| Some(error.clone())); | ||
| Outcome::Error((Status::BadRequest, error)) | ||
| } | ||
| Some(res) => match res.parse::<usize>() { |
There was a problem hiding this comment.
I know this is a little pedantic but perhaps worthwhile using the NonZeroU64.
I have an example in the PR I made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented functionality to import your repo to RSky PDS.
Reasons users may want to do that include but are not limited to: