Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load external JS via https #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Load external JS via https #184

wants to merge 1 commit into from

Conversation

tfreier
Copy link

@tfreier tfreier commented Apr 2, 2014

This is just a small improvement. I noticed Chrome was complaining about this lib because I access my sugar instance via https. I noticed all the other references were already using https links.

@blak3r
Copy link
Owner

blak3r commented Apr 2, 2014

Thanks!

Sent via mobile

On Apr 2, 2014, at 1:29 AM, Till Freier [email protected] wrote:

This is just a small improvement. I noticed Chrome was complaining about this lib because I access my sugar instance via https. I noticed all the other references were already using https links.

You can merge this Pull Request by running

git pull https://github.com/tfreier/yaai master
Or view, comment on, or merge it at:

#184

Commit Summary

load google api JS via https
File Changes

M SugarModules/modules/Asterisk/include/AsteriskJS.php (2)
Patch Links:

https://github.com/blak3r/yaai/pull/184.patch
https://github.com/blak3r/yaai/pull/184.diff

Reply to this email directly or view it on GitHub.

@pgorod
Copy link

pgorod commented Jun 11, 2018

@tfreier I know you from the SuiteCRM GitHub, and seeing you here on the Callinize site makes me want to ask you if you have this running well with SuiteCRM? Any changes needed?

I don't need this myself, but a user on the Forums is asking about it and I would like to have some integration with Asterisk available for free (even if it is only the basic version of a licensed product). Thanks

@umairmalik2410
Copy link

We're using this base code but had to make changes in order to get this running. Especially if they are using asterisk 13, then more changes would be required.

@tfreier
Copy link
Author

tfreier commented Jun 15, 2018

@pgorod We used to but only for about a year since it wasn't working well. After that, we wrote our own tool to handle the call integration: https://github.com/tfreier/desktop-crm

However, now we are also not using that anymore. We switched to pipedrive about a year ago. We don't have a call integration there anymore either but the email integration is just so much better.

@pgorod
Copy link

pgorod commented Jun 15, 2018

Ok, thanks. And sorry to everyone for hijacking this thread! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants