Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Odo documentation/code for sqlalchemy_redshift #489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,13 @@ install:

# Install various deps
- conda uninstall toolz
- pip install -U toolz sas7bdat psycopg2 dill 'pymongo<3'
- pip install -U toolz sas7bdat psycopg2 dill 'pymongo<3' sqlalchemy-redshift
- pip install git+git://github.com/blaze/dask.git#egg=dask-dev[complete]
- if [ -n "$PANDAS_VERSION" ]; then pip install $PANDAS_VERSION; fi

# install pyspark
- if [[ $TRAVIS_PYTHON_VERSION == '2.7' || $TRAVIS_PYTHON_VERSION == '3.4' ]]; then conda install spark=$SPARK_VERSION -c blaze -c https://conda.binstar.org/blaze/channel/dev -c anaconda-cluster; fi

# redshift sqlalchemy dialect
- pip install --upgrade git+git://github.com/graingert/redshift_sqlalchemy

# Before_script section stolen from fabric
# See license https://github.com/fabric/fabric/blob/master/LICENSE
before_script:
Expand Down
4 changes: 2 additions & 2 deletions docs/source/aws.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Dependencies
* `boto <http://boto.readthedocs.org>`_
* `sqlalchemy <http://docs.sqlalchemy.org/en/rel_0_9>`_
* `psycopg2 <http://initd.org/psycopg>`_
* `redshift_sqlalchemy <https://github.com/cpcloud/redshift_sqlalchemy>`_
* `sqlalchemy_redshift <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift>`_

Setup
-----
Expand All @@ -28,7 +28,7 @@ Interface
``odo`` provides access to the following AWS services:

* `S3 <http://aws.amazon.com/s3>`_ via boto.
* `Redshift <http://aws.amazon.com/redshift>`_ via a `SQLAlchemy dialect <https://github.com/cpcloud/redshift_sqlalchemy>`_
* `Redshift <http://aws.amazon.com/redshift>`_ via a `SQLAlchemy dialect <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift>`_

URIs
----
Expand Down
2 changes: 2 additions & 0 deletions docs/source/whatsnew/0.5.1.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ None
Improved Backends
-----------------

* Sqlalchemy-redshift upgraded to 5.0 and installed from PyPI (:issue: `478`).

None

API Changes
Expand Down
2 changes: 1 addition & 1 deletion odo/backends/sql_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def compile_from_csv_postgres(element, compiler, **kwargs):
try:
import boto
from odo.backends.aws import S3
from redshift_sqlalchemy.dialect import CopyCommand
from sqlalchemy_redshift.dialect import CopyCommand
except ImportError:
pass
else:
Expand Down
2 changes: 1 addition & 1 deletion odo/backends/tests/test_s3_redshift.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
sa = pytest.importorskip('sqlalchemy')
boto = pytest.importorskip('boto')
pytest.importorskip('psycopg2')
pytest.importorskip('redshift_sqlalchemy')
pytest.importorskip('sqlalchemy_redshift')

from contextlib import closing
import json
Expand Down