Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "gulp" function #27

Closed
mootz12 opened this issue Jan 8, 2025 · 0 comments · Fixed by #31
Closed

Add "gulp" function #27

mootz12 opened this issue Jan 8, 2025 · 0 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mootz12
Copy link
Contributor

mootz12 commented Jan 8, 2025

There are lots of rebasing tokens out in the wild. These are difficult to use with Blend pools, as the Blend pool is the holder of the token, thus any additional tokens earned go to the Blend pool and will not be accounted for.

Add a gulp(asset: Address) function to the Pool contract that updates the b_rate based on the expected balance of tokens in the pool verse the actual balance of tokens in the pool.

Technical Notes

While it should be impossible, gulp(asset: Address) can also result in a b_rate loss, given some unaccounted for loss of tokens in the pool (for example, a bug in the token contract)

@mootz12 mootz12 added enhancement New feature or request good first issue Good for newcomers labels Jan 8, 2025
@Ryang-21 Ryang-21 self-assigned this Jan 9, 2025
@Ryang-21 Ryang-21 mentioned this issue Jan 13, 2025
@mootz12 mootz12 linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants