Pool Gulp #31
Merged
Pool Gulp #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mootz12
requested changes
Jan 14, 2025
pool/src/emissions/distributor.rs
Outdated
| @@ -145,7 +145,7 @@ fn claim_emissions( | |||
| /// | |||
| /// ### Panics | |||
| /// If the reserve update failed | |||
| pub(super) fn update_emission_data( | |||
| pub fn update_emission_data( | |||
There was a problem hiding this comment.
This can remain pub(super)
pool/src/pool/gulp.rs
Outdated
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use std::println; |
pool/src/contract.rs
Outdated
Comment on lines
198
to
199
| /// Updates the reserve's B token supply to match the pool's asset balance | ||
| /// |
There was a problem hiding this comment.
Can we add a bit more color to this comment?
/// Update the reserve's bToken rate based on the pool's balance. This is useful for tokens where
/// a holder's balance can increase outside of a direct transfer.
pool/src/events.rs
Outdated
| @@ -274,6 +274,20 @@ impl PoolEvents { | |||
| e.events().publish(topics, (tokens_in, d_tokens_burnt)); | |||
| } | |||
|
|
|||
| /// Emitted when a reserve updates its supply to its token balance | |||
pool/src/pool/reserve.rs
Outdated
| @@ -128,6 +113,26 @@ impl Reserve { | |||
| storage::set_res_data(e, &self.asset, &reserve_data); | |||
| } | |||
|
|
|||
| /// Update the reserve's b_rate and the pool's backstop rate based on the difference in the pools token balance and the reserves stored balance. | |||
There was a problem hiding this comment.
This is a bit confusing, how about:
Accrue tokens to the reserve supply. This issues any `backstop_credit` required and updates the reserve's bRate to account for the additional tokens.
### Arguments
* bstop_rate - The backstop take rate for the pool
* accrued - The amount of additional underlying tokens
Closed
mootz12
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Add "gulp" function #27