change reserve emissions config from percent rate to weights

[celestialkylin]

Hello,

I noticed that the share in the emissions configuration is being used directly as a percentage rate. If the total share does not equal 1_0000000, some emissions may be lost when invoking the do_gulp_emissions function.

How about changing the share value from a percentage rate to a weight? This could help prevent emissions from being lost and make the emissions configuration easier to manage.

Additionally, when considering the asset disabling feature, I suggest ignoring the emissions that are sent to the disabled asset as well. With this change, it would be easier to disregard the share of the disabled asset and redistribute the remaining emissions to the other reserves.

[mootz12]

👋

Thanks for the PR!

This is a good point about asset disabling, that could make this change worth while.

The original design was done this way instead of shares due to clarity and rounding concerns. With shares, each "share" ends up getting rounded down, then the amount of tokens is rounded down again, rather than the shares being exact. This might not make much of an impact to actual emissions numbers, tho.

I'll look into it and get back here!

[celestialkylin]

Thanks for your reply.

Regarding the rounding-down impact, I have a solution. Do you think this can be accepted? The idea is to add the remaining emissions caused by rounding to a random emission element.

Additionally, the disabled asset can be filtered out in the first for-loop by adding some extra code.

Best regards

[mootz12]

@celestialkylin

Got time to look into how impactful rounding down can be if we opt use weights, and the impact is pretty minimal.

With extremely unoptimized weights (say, emitting to 10 different assets and all 10 get rounded down) this means about 0.0001% of emissions are lost to rounding.

This could also easily be fixed by the pool creator by adjusting the weights, minimizing the impact even more. Thus, I think the simpler solution is a better solution here.

My suggestions:

• Revert back to just using the weights as was done in the first commit
• Remove the check for a share weight of 1 and the unit test https://github.com/blend-capital/blend-contracts-v2/blob/main/pool/src/emissions/manager.rs#L50-L52
• Add a check that metadata.share > 0 before we include it in the pool emissions list and unit test that it throws a BadRequest error: https://github.com/blend-capital/blend-contracts-v2/blob/main/pool/src/emissions/manager.rs#L46

I think this change helps a lot when handling disabled assets, so would be happy to merge once the suggestions are addressed.

Thanks for the contribution!

[celestialkylin]

Hello @mootz, this is the modification based on your suggestion. Thanks!

[mootz12]

LG2M!