Skip to content

Commit

Permalink
fixes unittests for CertificateManager
Browse files Browse the repository at this point in the history
  • Loading branch information
srcansiz committed Feb 1, 2023
1 parent 14e96a9 commit 6224ad9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fedbiomed/common/certificate_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def write_mpc_certificates_for_experiment(
self,
parties: List[str],
path_certificates: str,
path_ips:str,
path_ips: str,
self_id: str,
self_ip: str,
self_port: int,
Expand Down
13 changes: 10 additions & 3 deletions tests/test_certificate_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ def test_07_certificate_manager_write_mpc_certificates_for_experiment(

arguments = {
"parties": ["id-1", "id-2", "id-3"],
"path": "/dummy/path",
"path_certificates": "/dummy/path",
"path_ips": "/dummy/path",
"self_id": "id-2",
"self_ip": "1.1.1.1",
"self_port": 12345,
Expand All @@ -228,6 +229,11 @@ def test_07_certificate_manager_write_mpc_certificates_for_experiment(
with self.assertRaises(FedbiomedCertificateError):
self.cm.write_mpc_certificates_for_experiment(**arguments)

self.mock_isdir.side_effect = [True, False]
with self.assertRaises(FedbiomedCertificateError):
self.cm.write_mpc_certificates_for_experiment(**arguments)

self.mock_isdir.side_effect = None
self.mock_isdir.return_value = True
self.mock_isfile.return_value = True

Expand Down Expand Up @@ -272,9 +278,10 @@ def get_side_effect(party):
self.assertEqual(mock_write_certificate_file.call_args_list[3][0], ('/dummy/path/P2.pem', 'cert-id-3'))

# Check if the result is as expected
self.assertListEqual(
self.assertTupleEqual(
result,
['/dummy/path/P0.pem', '/dummy/path/P1.key', '/dummy/path/P1.pem', '/dummy/path/P2.pem'])
('/dummy/path/ip_addresses', ['/dummy/path/P0.pem', '/dummy/path/P1.key',
'/dummy/path/P1.pem', '/dummy/path/P2.pem']))

mock_cm_get.side_effect = None
mock_cm_get.return_value = {}
Expand Down

0 comments on commit 6224ad9

Please sign in to comment.