Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move difficulty from ChaindHeader to IConsensus #284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dangershony
Copy link
Member

No description provided.

@soma42
Copy link
Contributor

soma42 commented Feb 23, 2021

Ok, to start somewhere...:

  • I understand, a chain needs to implement it's own class that implements IConsensus, e.g. x42Consensus, X1Consensus, ... to implement a custom Target calculation, right?

I think this is not all what is required, GetNextTargetRequired in StakeValidator also needs to be moved to IConsensus! For example, X1 needs that, because it modifies PoS/PoW Target, not only PoW Target. Makes sense?

@dangershony
Copy link
Member Author

I think this is not all what is required, GetNextTargetRequired in StakeValidator also needs to be moved to IConsensus! For example, X1 needs that, because it modifies PoS/PoW Target, not only PoW Target. Makes sense?

ahh well I sort of left POS out of it, mainly because POS has different requirements and is used in different classes even.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants