Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] EIP-1559 Integrity check #600

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[Fix] EIP-1559 Integrity check #600

merged 3 commits into from
Dec 18, 2023

Conversation

julianariel
Copy link
Contributor

Name of the feature/issue

EIP-1559 Integrity check

Description

Added new EIP1559 integrity check to force fetching the value again when we detect inconsistency between the value and the stored baseFee. We detected this situation on some old states from users which tried to perform an operation and received an error.

After checking the state, we noticed that some chains had the EIP-1559 flag with a false value when it should be true. The situation was automatically fixed after switching networks but it seems some users only operate with one network so this check should prevent this situation from happening again (i.e. a non EIP network upgrades to EIP-1559)

@julianariel julianariel self-assigned this Dec 13, 2023
@julianariel julianariel requested review from a team as code owners December 13, 2023 19:06
Copy link
Contributor

@MartnLecam MartnLecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianariel julianariel merged commit f206b3d into master Dec 18, 2023
3 checks passed
@julianariel julianariel deleted the fix/eip1559-integrity branch December 18, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants