feat: implement notifications handling for extension logs #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lily-de
changed the title
|
This is great - lots of people asking about this will help a lot. A couple thoughts:
|
baxen
reviewed
Feb 27, 2025
|
|
||
| // Set up logging in the default cache directory | ||
| println!("Setting up logging for extension {}", config.name()); | ||
| let log_path = format!("{}/.cache/goose/logs/{}.log", |
There was a problem hiding this comment.
nit: use the etcetera crate like in other logging
|
|
||
| use super::LogMessage; | ||
|
|
||
| pub struct FileLogger { |
There was a problem hiding this comment.
nit: i wonder if it would be more consistent/easier to forward to tracing? please disregard if that adds a lot of complexity, but off the top of my head it might make it easier to control both file and stderr based logging etc
wendytang
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow developers to view logs from their extensions (servers). For the MCP protocol, logs are emitted as notification-type messages, so this PR expands how we handle server responses to include notifications.