Feat/sofi landing #6170
Merged
Feat/sofi landing #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLeoB
requested review from
milan-bc,
jjBlockchain,
dkremniov-bc,
mperdomo-bc,
mrodriguez-bc and
CTucker-BC
as code owners
TheLeoB
commented
Dec 11, 2023
TheLeoB
commented
Dec 11, 2023
|
|
||
| const SofiMigration = ({ buySellActions, cacheActions, fiatCurrency }: Props) => { | ||
| const showModal = useCallback(() => { | ||
| buySellActions.showModal({ origin: 'WelcomeModal' }) |
TheLeoB
commented
Dec 11, 2023
| @@ -242,9 +243,22 @@ export const getData = (state: RootState) => { | |||
| let bannerToShow: BannerType = null | |||
|
|
|||
| const isKycEnabled = products?.kycVerification?.enabled | |||
| // SOFI | |||
| const sofiMigrationPending = selectors.modules.profile | |||
There was a problem hiding this comment.
see if i can optimize this logic
TheLeoB
commented
Dec 11, 2023
| @@ -0,0 +1,93 @@ | |||
| import React from 'react' | |||
TheLeoB
commented
Dec 11, 2023
| if (isEmailVerified) { | ||
| if (hasCowboyTag) { | ||
| // When the user has the COWBOYS_2022 tag set from the backend we want to skip | ||
| // the user straight to the dashboard and launch them into the Cowboys promo flyout | ||
| nextProps.routerActions.push('/home') | ||
| nextProps.saveGoal('cowboys2022', { firstLogin: true }) | ||
| nextProps.runGoals() | ||
| } else if (isSofi) { |
There was a problem hiding this comment.
we may associate before email verification
TheLeoB
commented
Dec 11, 2023
| @@ -36,3 +36,13 @@ export const isBrowserSafari = () => { | |||
| safari: '>12' | |||
| }) | |||
| } | |||
|
|
|||
| export const isBrowserAndroid = () => { | |||
There was a problem hiding this comment.
double check with android team if this is always the case for OS system
TheLeoB
commented
Dec 11, 2023
| if (browser.getOSName() === 'Android') return true | ||
| } | ||
|
|
||
| export const isBrowserIOS = () => { |
There was a problem hiding this comment.
add a fallback to show both mobile links if anything is undefined
TheLeoB
commented
Dec 11, 2023
jjBlockchain
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (optional)
Add a concise explanation of the changes.
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.