Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was documenting integration tests and noticed two issues with reported coverage. This PR fixes them.
We used
npx kill-port 3000
in CI, which stoppednext start
with SIGKILL instead of SIGINT. Abrupt process termination meant that the runtime coverage was not reported. I have temporarily replacedyarn kill-port
withkill -2
(i.e. SIGKILL with SIGINT). We can switch back when Add option for kill signal tiaanduplessis/kill-port#48 is closed upstream.↑ this change increased reported code coverage
We did not have
@istanbuljs/nyc-config-typescript
in.nycrc.json
, which caused some source files to be missing from the list of all files. In particular, allsite/src/pages/api/**.ts
files were not included into the report. Adding@istanbuljs/nyc-config-typescript
made the list of files more complete.↑ this change decreased reported code coverage
Overall coverage has decreased, but this is expected.