Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deploy-script): favicon generator #2466

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(deploy-script): favicon generator #2466

merged 1 commit into from
Dec 13, 2024

Conversation

MaxMustermann2
Copy link
Contributor

Description and Related Issue(s)

Without this change, the script tries to execute an index.js located in a folder that does not have such a file.

Proposed Changes

Use the correct folder, that is, the current working directory, to run the favicon generator.

Breaking or Incompatible Changes

None.

Additional Information

Running the script now also triggers a yarn install in the relevant directory.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@MaxMustermann2
fix(deploy-script): favicon generator
1db4dba 
Without this change, the script tries to execute an `index.js` located
in a folder that does not have such a file.
tom2drum
tom2drum approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted 👍
Thanks for your PR!

@tom2drum tom2drum merged commit 2915d95 into blockscout:main Dec 13, 2024
w875050772 added a commit to boolnetwork/boolscan that referenced this pull request Dec 23, 2024
@w875050772
Merge branch 'ultra' of https://github.com/boolnetwork/boolscan into …
d2d1f65 
…br-customized-retrofits-ultra

* 'ultra' of https://github.com/boolnetwork/boolscan: (1135 commits)
  Games (blockscout#2338)
  pools pages (blockscout#2468)
  Advanced filter (blockscout#1905)
  Call the API logout endpoint when the user logs out (blockscout#2469)
  Update Merits dashboard (blockscout#2456)
  Migrate from `web3modal` to `reown` (blockscout#2321)
  Support CDN for NFT images (blockscout#2461)
  change default description (blockscout#2470)
  Replace system selectors with Blockscout selectors style (blockscout#2451)
  [skip ci] fix favicon generator dev script
  fix(deploy-script): favicon generator (blockscout#2466)
  Support verification of Stylus contracts (blockscout#2450)
  fix block miner highlight style (blockscout#2459)
  SEO Tweaks for Gas Tracker Page (blockscout#2344)
  ReCaptcha: migrate back to v2 solution (blockscout#2446)
  Zilliqa: filter for Scilla contracts (blockscout#2449)
  Add Nouns pfps (blockscout#2447)
  Remove Canny from footer section (blockscout#2442)
  Scroll views (blockscout#2418)
  Improve grammar, capitalization, and consistency (blockscout#2432)
  ...

# Conflicts:
#	.eslintrc.js
#	.gitignore
#	configs/app/chain.ts
#	configs/app/ui.ts
#	configs/app/utils.ts
#	configs/envs/.env.main
#	deploy/tools/envs-validator/schema.ts
#	docs/ENVS.md
#	icons/clock-light.svg
#	icons/empty_search_result.svg
#	icons/wallet.svg
#	lib/api/buildUrl.ts
#	lib/api/resources.ts
#	lib/api/useApiQuery.tsx
#	lib/hooks/useFetch.tsx
#	lib/hooks/useNavItems.tsx
#	lib/metadata/getPageOgType.ts
#	lib/metadata/templates/description.ts
#	lib/metadata/templates/title.ts
#	lib/mixpanel/getPageType.ts
#	nextjs/nextjs-routes.d.ts
#	package.json
#	public/favicon/apple-touch-icon.png
#	public/favicon/favicon-16x16.png
#	public/favicon/favicon-32x32.png
#	public/favicon/favicon.ico
#	public/favicon_back/apple-touch-icon-120x120.png
#	public/favicon_back/apple-touch-icon-152x152.png
#	public/favicon_back/apple-touch-icon-180x180.png
#	public/favicon_back/apple-touch-icon-60x60.png
#	public/favicon_back/apple-touch-icon-76x76.png
#	public/favicon_back/safari-pinned-tab.svg
#	public/icons/name.d.ts
#	stubs/utils.ts
#	theme/foundations/colors.ts
#	types/api/transaction.ts
#	ui/address/contract/ContractConnectWallet.tsx
#	ui/home/Stats.tsx
#	ui/home/StatsItem.tsx
#	ui/home/indicators/ChainIndicators.tsx
#	ui/home/indicators/utils/indicators.tsx
#	ui/pages/Home.tsx
#	ui/shared/DetailsInfoItem.tsx
#	ui/shared/GasInfoTooltipContent/GasInfoRow.tsx
#	ui/shared/pagination/useQueryWithPages.ts
#	ui/snippets/footer/Footer.tsx
#	ui/snippets/navigation/vertical/NavigationDesktop.tsx
#	ui/snippets/searchBar/SearchBarInput.tsx
#	ui/snippets/topBar/ColorModeSwitch.tsx
#	ui/snippets/topBar/ColorModeSwitchTheme.tsx
#	ui/snippets/topBar/TopBarStats.tsx
#	ui/snippets/walletMenu/WalletMenuDesktop.tsx
#	ui/stats/NumberWidget.tsx
#	ui/stats/NumberWidgetsList.tsx
#	ui/stats/StatsDropdownMenu.tsx
#	ui/tx/TxInternals.tsx
#	ui/tx/internals/TxInternalsList.tsx
#	ui/tx/internals/TxInternalsTable.tsx
#	ui/txs/TxType.tsx
#	ui/txs/TxsTableItem.tsx
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxMustermann2 @tom2drum