Heavy lag when using a ME Crafting Interface; constantly recalculating EMI's "craftables"?

[unilock]

When AE2 EMI Crafitng Integration is installed in my (very large) modpack, the game repeatedly freezes every time I do something in an AE2 ME Crafting Interface. (moving items into the crafting grid, taking items out of the crafting grid, etc.)

From a log generated with spark, it seems to be constantly recalculating EMI's "craftables"? https://spark.lucko.me/ZgK1KYyjaO

latest.log: https://gist.github.com/unilock/61cf7f486d325f3a8f1c19efed2b10ad

Note that AE2's built-in JEI integration appears to work fine via JEMI, so I've been relying on that instead.

[alikindsys]

oh lord. try disabling that feature until I optimize it, the latest version has an option to disable emi syncing which also disables this code path iirc. if it doesn't just downgrade to 1.3.0 since that version doesn't have that feature added.

can you also give me your modpacks/mod list for testing on something that stresses the mod out?

[Ftrless]

Btw I noticed this too, only on older versions mod, at that point I just put it in a separate thread and it helped

[unilock]

the latest version has an option to disable emi syncing

I've already been testing with "BOM Syncing" disabled, unfortunately.

if it doesn't just downgrade to 1.3.0 since that version doesn't have that feature added.

If I remember correctly, I had the same(? or at least a similar) problem on older versions of the mod as well.

can you also give me your modpacks/mod list for testing on something that stresses the mod out?

Here's a recent Prism Launcher export of the modpack I'm using: https://mega.nz/file/xssEBaZZ#8loKITZKbzxVISOCC_dVoMdLnjIpUYk6EebYHmXVRPI
(it may need AE2 EMI Crafting Integration re-added)

[alikindsys]

The issue here is really wierd, since the hot path is caused by ae2's findMissingIngredients. Craftables aren't what is being recalculated here, and honestly nothing should be recalculated.

The problem is, in modpacks with a lot of crafting recipes, EMI will check the craftability of each one of those recipes with the canCraft function, which is implmemented in the same way as the official AE2 extension afaik (or at least it was once i was backporting their mod integration).

They since changed to fix to only use the findMissingIngredients logic if you are pressing the fill button. If the context is part of the api for 1.20.1 and earlier i can fix that cleanly, otherwise that will break the searching for recipes logic.

    @Override
    public boolean canCraft(EmiRecipe recipe, EmiCraftContext<T> context) {
        if (context.getType() == EmiCraftContext.Type.FILL_BUTTON) {
            return transferRecipe(recipe, context, false).canCraft();
        }
        return StandardRecipeHandler.super.canCraft(recipe, context);
    }

[alikindsys]

This should fix the lag since this version has their fix. the only thing that might got broken was that the craftables tab wont see the contents of the ME system, regardless of bom sync value. If this fixes the problem i'll reimplement the syncing later.

ae2-emi-crafting-1.3.1-dev.zip

[Ftrless]

    @Override
    public boolean canCraft(EmiRecipe recipe, EmiCraftContext<T> context) {
        if (context.getType() == EmiCraftContext.Type.FILL_BUTTON) {
            return transferRecipe(recipe, context, false).canCraft();
        }
        return StandardRecipeHandler.super.canCraft(recipe, context);
    }

This implementation also breaks grid filling when you click on the desired craft rbm with shift held down (at least at me)

[Ftrless]

@unilock there any results?

[unilock]

This should fix the lag since this version has their fix. the only thing that might got broken was that the craftables tab wont see the contents of the ME system, regardless of bom sync value. If this fixes the problem i'll reimplement the syncing later.

This build does appear to fix the problem, thanks! (Note that I personally do not use the "craftables" tab, so that remains untested.)

[alikindsys]

I can't test unilock's modpack due to hardware limitations. I've reduced the amount of calls to the offending function and that should make it 3x less laggy. I'll likely put that under a toggle since it should only ever be a problem with really large packs (and this is likely an issue with forge in specific since this mod is used on a large lunapixel studio modpack).

IIRC forge did a lot of changes to minecrafts vanilla registry in order to load mods multithreaded (in an attempt to make mod loading faster) and those changes could also be what causes the lag. I'd have to properly support forge to see if that fixes the problem since connector could try as they might to make fabric mods load on forge but there will be edge cases and I'm inclined to believe this is one of them.

[alikindsys]

Fixed

Dev: baccca2
MR: Waiting for Release
CF: Waiting for Release

[NickAcPT]

Fixed

Dev: baccca2 MR: Waiting for Release CF: Waiting for Release

@roridev I've been hitting this issue for a while now with a modpack I'm playing with some friends.

Is there any ETA on a version bump?