Fix/not changing the switched chain id in in app browser #288
Conversation
|
| @@ -872,7 +876,7 @@ export default class EthereumProvider | |||
| async handleDisconnect(): Promise<void> { | |||
| const existedSDK = (window as any).ethereum; | |||
| if (existedSDK && existedSDK.isBlocto) { | |||
| return existedSDK.disconnect(); | |||
| return existedSDK.request({ method: 'wallet_disconnect' }); | |||
There was a problem hiding this comment.
It seems that the disconnect function is not declared in the in-app-browser existedSDK, so I replaced it using request({ method: 'wallet_disconnect' })
| @@ -907,4 +911,20 @@ export default class EthereumProvider | |||
| throw ethErrors.rpc.invalidParams('Empty networkList'); | |||
| } | |||
| } | |||
|
|
|||
| override on(event: string, listener: (arg: any) => void): void { | |||
| if (this.existedSDK?.isBlocto) | |||
There was a problem hiding this comment.
I think the condition if (this.existedSDK?.isBlocto) is more concise and achieves the same effect as const existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto). If there are no issues, I'll replace const existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto) with it.
There was a problem hiding this comment.
I replaced all the const existedSDK = (window as any).ethereum; if (existedSDK && existedSDK.isBlocto) with if (this.existedSDK?.isBlocto) in this commit refactor: enhance existedSDK check condition
q20274982
force-pushed
the
fix/not-changing-the-switched-chain-id-in-in-app-browser
branch
2 times, most recently
from
0651bcd to
484d367
Compare
q20274982
force-pushed
the
fix/not-changing-the-switched-chain-id-in-in-app-browser
branch
from
e8155e5 to
44c70c7
Compare
solved here feat: enable aptos's existedSDK event |
q20274982
deleted the
fix/not-changing-the-switched-chain-id-in-in-app-browser
branch
…in-id-in-in-app-browser chore: add changeset for #288
Summary
by adding eventListeners to the
bloctoSDKand also adding it in the in-app browser's existedSDK,it allows invoking event functions in the in-app-browser as well.
Related Links
Asana: https://app.asana.com/0/1201812548509877/1205706441564006/f
Checklist
Prerequisite/Related Pull Requests