Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/existed sdk handle window not defined #372

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

q20274982
Copy link
Member

Summary

handle when server side render, bloctoSDK occur window is not defined

Related Links

Asana:

Checklist

  • Pasted Asana link.
  • Tagged labels.

Prerequisite/Related Pull Requests

@q20274982 q20274982 added the bug Something isn't working label Jan 12, 2024
@q20274982 q20274982 requested a review from sanyu1225 January 12, 2024 06:00
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: d0a91c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blocto/aptos-wallet-adapter-plugin Patch
@blocto/connectkit-connector Patch
@blocto/rainbowkit-connector Patch
@blocto/web3-react-connector Patch
@blocto/web3modal-connector Patch
@blocto/wagmi-connector Patch
@blocto/sdk Patch
@blocto/dappauth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@q20274982 q20274982 marked this pull request as ready for review January 12, 2024 06:00
sanyu1225
sanyu1225 previously approved these changes Jan 12, 2024
@mordochi
Copy link
Member

Aptos 的順便幫修!然後這裡好像也需要檢查 謝謝

@q20274982 q20274982 force-pushed the fix/existedSDK-handle-window-not-defined branch from 117a332 to cba22a2 Compare January 12, 2024 06:41
@q20274982 q20274982 requested a review from sanyu1225 January 12, 2024 07:02
@q20274982 q20274982 requested review from mordochi and removed request for sanyu1225 January 12, 2024 07:20
@q20274982 q20274982 merged commit 90e9b4a into develop Jan 12, 2024
3 checks passed
@q20274982 q20274982 deleted the fix/existedSDK-handle-window-not-defined branch January 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working BugFix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants