Support adding and satisfying a constraint in the same txn #4948
+537
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Ponomarenko <[email protected]>
roborivers
suggested changes
Jan 6, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 305/598 tests failed ⚠.
The first 10 failing tests are:
odh_blobs [setup failure]
unionpar_maxqueue [setup failure]
sc_truncate_multiddl_generated [setup failure]
sc_inserts_logicalsc_generated [setup failure]
phys_rep_perf
online_compaction
timepart_trunc_serialsc_generated
timepart_trunc_multiddl_generated
timepart_trunc
constraints_partial_index_off_generated
morgando
force-pushed
the
tran-foreign-keys
branch
6 times, most recently
from
ed93701 to
abd9c36
Compare
roborivers
suggested changes
Jan 7, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 193/597 tests failed ⚠.
The first 10 failing tests are:
sc_inserts_logicalsc_generated [setup failure]
sc_newuniq [setup failure]
writes_remsql_fdbpushredirect_generated [setup failure]
sorese_tran [setup failure]
sc_transactional_rowlocks_generated
phys_rep_perf
analyze_exit_immediately
timepart_trunc_serialsc_generated
timepart_trunc_multiddl_generated
timepart_trunc
morgando
changed the title
morgando
force-pushed
the
tran-foreign-keys
branch
8 times, most recently
from
23fc18f to
2e1645e
Compare
Signed-off-by: Morgan Douglas <[email protected]> Tweak replicant impl Signed-off-by: Morgan Douglas <[email protected]> Tweak repl impl Signed-off-by: Morgan Douglas <[email protected]> Tweak repl impl Signed-off-by: Morgan Douglas <[email protected]> Refactor master impl for supporting adding+satisfying constraint in the same txn Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]> Tweak impl Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]> Tweak test Signed-off-by: Morgan Douglas <[email protected]> Tweak test Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Teak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]>
morgando
force-pushed
the
tran-foreign-keys
branch
from
611ee1b to
65df3c7
Compare
in a txn (1) constraint is added (2) constraint is satisfied with an alter during the scdone step for (2), replicants will assume that, since there is a constraint pointing to the table getting altered, the target key must have existed in the table before it got altered. This was previously a sound assumption because it was not possible to first add a constraint before satisfying it in the same transaction, which is the only case where this can validly occur. The changes in this commit 'pass' the compatibility check if we can't find the key that we're trying to validate in the pre-alter dbtable. TODO: make sure other compatibility checks in ondisk_schema_change aren't buggy. Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
morgando
commented
Jan 15, 2025
schemachange/sc_alter_table.c
Outdated
| @@ -1042,6 +1061,7 @@ int finalize_alter_table(struct ireq *iq, struct schema_change_type *s, | |||
|
|
|||
| free_db_and_replace(db, newdb); | |||
| fix_constraint_pointers(db, newdb); | |||
| try_to_populate_missing_reverse_constraints(NULL); // TODO: Don't suppress errors | |||
There was a problem hiding this comment.
Is this necessary?
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.