Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDSICOMDB2-292: Provide a reason for main data rebuild #4953

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

riverszhang89
Copy link
Contributor

This is a feature requested by our DBA team to help them better categorize risk levels of schema changes.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 231/597 tests failed ⚠.

The first 10 failing tests are:
comdb2sys_queueodh_generated [setup failure]
selectv_range [setup failure]
writes_remsql_names_negativerowid_generated [setup failure]
vutf8_rowlocks [setup failure]
phys_rep_perf
printlog
online_compaction
comdb2sys_pagesize_generated
comdb2sys
snapisol_partial_index_off_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 5/595 tests failed ⚠.

The first 10 failing tests are:
replay_history [setup failure]
sc_transactional_rowlocks_generated
pglogs_seqnum
analyze_exit_immediately
dbcreate

This is a feature requested by our DBA team to help them better categorize
risk levels of schema changes.

Signed-off-by: Rivers Zhang <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/595 tests failed ⚠.

The first 10 failing tests are:
sc_transactional_rowlocks_generated

@riverszhang89
Copy link
Contributor Author

@mponomar Thanks for the review, Mike!

This branch also passes robomark: cdb2test Jan 28 17:41:32 2025 success sc_tag_change_subtype.R20250128.6

@riverszhang89 riverszhang89 merged commit 4c1d00a into bloomberg:main Jan 29, 2025
1 check passed
@riverszhang89 riverszhang89 deleted the sc_tag_change_subtype branch January 29, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants