Skip to content

Commit

Permalink
Finishing touches
Browse files Browse the repository at this point in the history
  • Loading branch information
pizzaboxer committed Oct 2, 2024
1 parent 8764804 commit 6cb1ca6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions Bloxstrap/Bootstrapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -401,14 +401,11 @@ private void StartRoblox()
if (App.LaunchSettings.TestModeFlag.Active)
args += " -testmode";

// TODO: look into if this needs to be launched *before* roblox starts
if (ipl.IsAcquired)
Process.Start(Paths.Process, args);
}
}

// TODO: the bootstrapper dialogs call this function directly.
// this should probably be behind an event invocation.
public void Cancel()
{
const string LOG_IDENT = "Bootstrapper::Cancel";
Expand Down Expand Up @@ -660,10 +657,6 @@ private async Task UpgradeRoblox()

if (Dialog is not null)
{
// allow progress bar to 100% before continuing (purely ux reasons lol)
// TODO: come up with a better way of handling this that is non-blocking
await Task.Delay(1000);

Dialog.ProgressStyle = ProgressBarStyle.Marquee;
SetStatus(Strings.Bootstrapper_Status_Configuring);
}
Expand Down Expand Up @@ -994,9 +987,6 @@ private async Task DownloadPackage(Package package)
if (File.Exists(package.DownloadPath))
return;

// TODO: telemetry for this. chances are that this is completely unnecessary and that it can be removed.
// but, we need to ensure this doesn't work before we can do that.

const int maxTries = 5;

bool statIsRetrying = false;
Expand Down
2 changes: 1 addition & 1 deletion Bloxstrap/UI/Elements/About/Pages/AboutPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
<controls:MarkdownTextBlock MarkdownText="[CubesterYT](https://github.com/CubesterYT)" />
<controls:MarkdownTextBlock MarkdownText="[TheRealSpriteMan1337](https://github.com/TheRealSpriteMan1337)" />
<controls:MarkdownTextBlock MarkdownText="[ms-gitblox](https://github.com/ms-gitblox)" />
<controls:MarkdownTextBlock MarkdownText="[ Luximoz](https://github.com/ Luximoz)" />
<controls:MarkdownTextBlock MarkdownText="[Luximoz](https://github.com/Luximoz)" />
</StackPanel>
</controls:Expander>

Expand Down

0 comments on commit 6cb1ca6

Please sign in to comment.