Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enhance performance tests and add insertion_and_removal #53

Merged
merged 5 commits into from
Jan 4, 2025
Merged

test: Enhance performance tests and add insertion_and_removal #53

merged 5 commits into from
Jan 4, 2025

Conversation

luanpotter
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Benchmark Results

Package ordered_set:

Benchmarks Current Branch
[luan.better-perf]		 Base Branch
[main]		 Diff
Iteration Benchmark 260.959 μs 252.517 μs 🔴 +3.343 %
Insertion and Removal Benchmark 336.199 μs [-] [-]
Comprehensive Benchmark 15495.701 μs 166874.667 μs 🟢 -90.714 %

Benchmarks provided with 💙 by Dart Benchmark Action.

luanpotter
luanpotter commented Jan 2, 2025
View reviewed changes
benchmark/comprehensive_benchmark.dart
const _maxElement = 10000;
const _startingSetSize = 500;
const _startingSetSize = 250;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to put it in line with the time of the other tests. with the new impl it is totally fine to go even above these numbers

@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12606149641

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.345%
Totals Coverage Status
Change from base Build 12590315968: 0.0%
Covered Lines: 110
Relevant Lines: 113
💛 - Coveralls

@luanpotter luanpotter requested a review from spydon January 2, 2025 22:03
spydon
spydon reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@luanpotter luanpotter requested a review from spydon January 3, 2025 21:49
spydon
spydon approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@spydon spydon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! This should have the test: conventional commit tag and not perf:, since it's not improving performance.

@luanpotter luanpotter changed the title perf: Enhance performance tests and add insertion_and_removal test: Enhance performance tests and add insertion_and_removal Jan 4, 2025
@luanpotter luanpotter merged commit 2495b5e into main Jan 4, 2025
6 checks passed
@luanpotter luanpotter deleted the luan.better-perf branch January 4, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanpotter @coveralls @spydon