feat: add the possibility to check if the body matches many expected strings #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strings A new array field response_contains, can contains many string to check To stay retro compatible with response_body_contains, we add the response_body_contains to the response_contains array.
colindickson
requested changes
May 7, 2019
tester/tester.go
Outdated
| @@ -39,9 +39,11 @@ type Contract struct { | |||
|
|
|||
| ExpectedHTTPCode int `json:"http_code_is" yaml:"http_code_is"` | |||
| ExpectedResponseBody string `json:"response_body_contains" yaml:"response_body_contains"` | |||
| ExpectedResponse []string `json:"response_contains" yaml:"response_contains"` | |||
There was a problem hiding this comment.
perhaps the plural ExpectedResponses would be better since this is a slice
colindickson
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new array field response_contains, can contains many string to check
To stay retro compatible with response_body_contains, we add the response_body_contains to the response_contains array.
I don't really like what the function to ensure the retro compatibility prepareResponseBody
Do you think we can add it elsewhere ?