Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delete Functionality #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Delete Functionality #9

wants to merge 2 commits into from

Conversation

harshal015
Copy link
Contributor

The delete button is working now!

@vj-codes
Copy link
Member

vj-codes commented Oct 1, 2022

@Harshal2502 hey can you add a demo of it working?

@harshal015
Copy link
Contributor Author

@VG-1 in what form? What about a GIF?

@vinayakgavariya
Copy link
Contributor

@VG-1 in what form? What about a GIF?

Yeah works.

@harshal015
Copy link
Contributor Author

@VG-1 The Working Demo 👇

Delete Functionality

@harshal015
Copy link
Contributor Author

harshal015 commented Oct 1, 2022 •
edited
Loading

@VG-1 @vj-codes Please tell if any changes are required

vj-codes
vj-codes approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR to the repository!
LGTM 🎉

vinayakgavariya
vinayakgavariya approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@vinayakgavariya vinayakgavariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to BlueLearn Open Source.
All the best.

@harshal015
Copy link
Contributor Author

thanks for accepting!

@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

✅ Deploy Preview for spiffy-mochi-75dc65 ready!

Name Link
🔨 Latest commit 39862a0
🔍 Latest deploy log https://app.netlify.com/sites/spiffy-mochi-75dc65/deploys/633af3b1a04c360008630b21
😎 Deploy Preview https://deploy-preview-9--spiffy-mochi-75dc65.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayakgavariya vinayakgavariya vinayakgavariya approved these changes

@vj-codes vj-codes vj-codes approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshal015 @vj-codes @vinayakgavariya