Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation picker #2579

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Apr 30, 2024

I think this is mostly ready. I'll re-check all the code and make the arrows reorient with the model

Screencast.from.2024-04-30.15-33-41.webm

@rafaellehmkuhl
Copy link
Member

This is muuuuuuuuuch better!!

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do something about the navigator model, 10MB looks insane.
The advantage is that we can now replace the svgs with hardcoded red squares with component highlights, like we do in the vehicle setup.

@Williangalvani
Copy link
Member Author

We should do something about the navigator model, 10MB looks insane. The advantage is that we can now replace the svgs with hardcoded red squares with component highlights, like we do in the vehicle setup.

huh, I had it down to 1.3mb. I think I forgot to enable compression on the latest export. will check.

@Williangalvani
Copy link
Member Author

Williangalvani commented Apr 30, 2024

We should do something about the navigator model, 10MB looks insane. The advantage is that we can now replace the svgs with hardcoded red squares with component highlights, like we do in the vehicle setup.

updated, good catch
1.15mb now

@Williangalvani Williangalvani force-pushed the orientation_picker branch 2 times, most recently from afa5b3c to d988b8f Compare October 25, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants