Add driver direction #110
Merged
Add driver direction #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickelectric can you solve the conflict? |
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
one-direction
branch
from
7b6eb47 to
8c6a93e
Compare
|
@joaoantoniocardoso check now |
joaoantoniocardoso
approved these changes
Jan 14, 2025
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 10)] | ||
| #[ignore] |
There was a problem hiding this comment.
The tests can't run in parallel, since will conflict with each other, I did run them serialized, but no luck, we need to improve this in the future.
There was a problem hiding this comment.
Hmm, I see. We have the same issue on the mavlink camera manager, but there the serial test works. This is one sad downside of using singletons :(
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
one-direction
branch
from
4a5483f to
27f1cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version that allows drivers to implement direction, allowing to receive or/and send