Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP: Add direction control #116

Merged

Conversation

patrickelectric
Copy link
Member

Signed-off-by: Patrick José Pereira [email protected]

Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
.to_string(),
url::Url::parse(&format!("{second_schema}://127.0.0.1:14660"))
url::Url::parse(&format!("{first_schema}://0.0.0.0:14550"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url::Url::parse(&format!("{first_schema}://0.0.0.0:14550"))
url::Url::parse(&format!("{first_schema}://0.0.0.0:14660"))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ip is also changing. Is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are looking into the wrong line.
The original code was

url::Url::parse(&format!("{first_schema}://0.0.0.0:14550"))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: the original port was 14660, and we are now changing it to 14550, which makes it inconsistent with the code at lines 221~225, which uses 14660:

           url::Url::parse(&format!(
                "{second_schema}://127.0.0.1:14660?direction=receiver"
            ))
            .unwrap()
            .to_string(),

it looked like a copy-paste mistake, that's why I'm asking if that's intentional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is the same, it's only the diff that looks that the numbers changed:

image

Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it once you decide about that port inconsistency that I was pointing out

@patrickelectric patrickelectric merged commit f83a120 into bluerobotics:master Feb 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants