-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge functions set_led #34
Merge functions set_led #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, just minor observations.
src/lib.rs
Outdated
for pin in self.as_mut_array().iter_mut() { | ||
pin.set_value(0).expect("Error: Set led value to 0"); | ||
pin.set_value((!state).into()) | ||
.unwrap_or_else(|_| panic!("Error: Set LED value to {}", state)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic!("Error: Set LED value to {state}");
@@ -682,22 +681,14 @@ impl Navigator { | |||
/// | |||
/// nav.init(); | |||
/// loop { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't there a 'no_run' statement missing here?
dcdd3ac
to
6f58d20
Compare
@RaulTrombin please rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs rebase
6f58d20
to
b2017fd
Compare
*Needs Merge & Rebase:
Merge set_led methods to a single one.
Corrects the open milestone issue: