Merge functions set_led #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.rs
Outdated
| for pin in self.as_mut_array().iter_mut() { | ||
| pin.set_value(0).expect("Error: Set led value to 0"); | ||
| pin.set_value((!state).into()) | ||
| .unwrap_or_else(|_| panic!("Error: Set LED value to {}", state)); |
There was a problem hiding this comment.
panic!("Error: Set LED value to {state}");| @@ -682,22 +681,14 @@ impl Navigator { | |||
| /// | |||
| /// nav.init(); | |||
| /// loop { | |||
There was a problem hiding this comment.
isn't there a 'no_run' statement missing here?
RaulTrombin
force-pushed
the
merge_functions_set_led
branch
from
dcdd3ac
to
6f58d20
Compare
|
@RaulTrombin please rebase. |
RaulTrombin
force-pushed
the
merge_functions_set_led
branch
from
6f58d20
to
b2017fd
Compare
patrickelectric
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Needs Merge & Rebase:
Merge set_led methods to a single one.
Corrects the open milestone issue: