src: lib: Change the sensor readings axes to navigator's standard #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just need to check/discuss the magnetic field, For 9-DOF sensors, generally seems to use like this: But actually, with this PR it's using same reference as Accel. |
RaulTrombin
force-pushed
the
axes_reference
branch
from
ec0d8fc
to
3644670
Compare
|
They are showing positive values when poiting to a magnetic south pole. According to the field vector. |
src/lib.rs
Outdated
| // Change the axes to navigator's standard. Right-handed, Z-axis down (aeronautical frame, NED). | ||
| AxisData { | ||
| x: y, | ||
| y: ((-1.0) * x), |
There was a problem hiding this comment.
why not just: x * -1.0 ?
RaulTrombin
force-pushed
the
axes_reference
branch
from
3644670
to
c99952e
Compare
patrickelectric
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensors readings now follows the aeronautical frame system, right-handed, Z-axis down.
https://www.mathworks.com/help/aeroblks/about-aerospace-coordinate-systems.html
Corrects the open milestone issue: