Projection configuration fix #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arghh....tests failing for jsonshema2 |
|
Added skips in some tests for less than jsonschema3. h/t to @danielballan |
|
Added value field to fix #194 |
danielballan
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue found that the projection schema does not have enough types.
Description
The projection schema's "location" field contained "event" and "configuration". This PR adds "start".
Motivation and Context
The initial commits for projections and projectors contained the mistaken notion that the only two places in a docstream that might want to be projected are the start document and event fields. It was realized later that event descriptr configuration fields would also want to be project. This PR adds "start" to the projection location enum, and changes the meaning of "configuration" from the start document to the event descriptor. Fixes
Additionally, fixes Fixes #183. This issue asked for more schema validation against calculated and liked fields. For example:
if type == calculated:
calcuation field is also required
if type == linked:
location field is also required
How Has This Been Tested?
Tests in test_projections added for checking validation changes.
This PR will have a corresponding PR in databroker.