Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pre-commit checks #272

Merged
merged 8 commits into from
Oct 19, 2023
Merged

add pre-commit checks #272

merged 8 commits into from
Oct 19, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added task hacktoberfest-accepted https://hacktoberfest.com/ labels Oct 17, 2023
@prjemian prjemian self-assigned this Oct 17, 2023
@prjemian
Copy link
Contributor Author

Since unit tests have been passing before this branch, comment out parts so that tests pass now as well.

In a separate issue, resolve issues noted when certain tests were commented out due to failure with existing code.

@prjemian prjemian added this to the v1.1 milestone Oct 17, 2023
@prjemian prjemian mentioned this pull request Oct 17, 2023
Closed
mrakitin
mrakitin reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Not sure why the linting checks were commented out.

.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml
Comment on lines +24 to +37
# - repo: https://github.com/pycqa/flake8
# rev: 4.0.1
# hooks:
# - id: flake8

# - repo: https://github.com/timothycrosley/isort
# rev: 5.12.0
# hooks:
# - id: isort

# - repo: https://github.com/psf/black
# rev: 22.8.0
# hooks:
# - id: black
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did those commented-out checks fail?

@prjemian
Copy link
Contributor Author

Yes, those checks failed as noted above. Figured that fixing then was not the job of this issue.

@prjemian prjemian merged commit b941e83 into main Oct 19, 2023
7 checks passed
@prjemian prjemian deleted the 263-precommit branch October 19, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
hacktoberfest-accepted https://hacktoberfest.com/ task
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

linting checks can be done via pre-commit
2 participants
@prjemian @mrakitin