-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward() should pick answer consistent with forward_solutions_table() and default decision function #315
Conversation
prjemian
commented
Dec 19, 2023
- close BUG: forward() does not give same answer as first solution in forward_solutions_table() #303
This PR passes its own tests. |
@jwkim-anl : Looks like a simple fix. @ambarb : Are you OK with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. The new test might have more rigid requirements than needed though.
LGTM Co-authored-by: Padraic Shafer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
@padraic-shafer @mrakitin Thanks! |