feat: Map GitLab Runner Docker Parameters #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabitosh
commented
Jul 14, 2024
fabitosh
force-pushed
the
fm/docker-cfg
branch
3 times, most recently
from
b6a31a1 to
2d1de05
Compare
cdbrkfxrpt
requested changes
Jul 20, 2024
cdbrkfxrpt
approved these changes
Jul 20, 2024
cdbrkfxrpt
approved these changes
Jul 21, 2024
GitLabRunners should have the freedom to determine them unless explicit requests exist.
cdbrkfxrpt
force-pushed
the
fm/docker-cfg
branch
from
45f94ab to
84faf39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently only exposing a minimal set of adjustable parameters to the REST API of runnrs. In an effort to prepare for advanced use-cases this PR maps all available Docker Executor parameters of the GitLab documentation to the glrcfg.
GitLab Runners Docker Section
We implement all types according to the specifications in the documentation. For parameters whose default is explicitly specified, it is taken over.